flowfi - #954
Conversation
|
heads up: main's ci was broken (the Backend CI and Backend Docker Image CI jobs) until the fixes in #969 and #974 just landed, so the red backend/docker checks on this pr are almost certainly stale, they ran against the broken main. please rebase to re-test against the now-green main: |
ogazboiz
left a comment
ogazboiz
left a comment
There was a problem hiding this comment.
the split pause/resume errors (StreamAlreadyPaused / StreamNotPaused) + tests are a good improvement. one real fix: cargo fmt --check fails on a stray blank line at contracts/stream_contract/src/errors.rs:33, run cargo fmt from contracts/ and commit. the backend/npm red is stale (unrelated files), so after cargo fmt, rebase on main and it'll go green.
ogazboiz
left a comment
ogazboiz
left a comment
There was a problem hiding this comment.
following up on the earlier review: the stray blank line at contracts/stream_contract/src/errors.rs:33 is still there (the only new commit is a merge of main, no fmt commit), so:
- run cargo fmt in contracts/ and commit.
- rebase once more now that main is green again (#1161 merged the CI fixes).
- optional but appreciated: give the PR a real title instead of "flowfi".
if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
2 participants
Closes #799
Closes #788
Closes #805